Skip to content

Remove locations#290

Merged
eccles merged 1 commit intomainfrom
dev/paul/10634-remove-locations
Apr 22, 2025
Merged

Remove locations#290
eccles merged 1 commit intomainfrom
dev/paul/10634-remove-locations

Conversation

@eccles
Copy link
Contributor

@eccles eccles commented Apr 7, 2025 •
edited
Loading 

Test results:

task functests
task: [about] ./scripts/builder.sh ./scripts/version.sh
task: [functests] ./scripts/builder.sh ./scripts/functests.sh
Python 3.9.21
test_access_policies_share_asset_with_different_attributes (functests.execaccess_policies.TestAccessPoliciesShare) ... skipped 'cannot run test as DATATRAILS_AUTHTOKEN_FILENAME_2 is not set'
test_access_policies_share_assets_symmetrically (functests.execaccess_policies.TestAccessPoliciesShare) ... skipped 'cannot run test as DATATRAILS_AUTHTOKEN_FILENAME_2 is not set'
test_access_policies_create (functests.execaccess_policies.TestAccessPoliciesSimple) ... ok
test_access_policies_delete (functests.execaccess_policies.TestAccessPoliciesSimple) ... ok
test_access_policies_list (functests.execaccess_policies.TestAccessPoliciesSimple) ... ok
test_access_policies_update (functests.execaccess_policies.TestAccessPoliciesSimple) ... ok
test_appidp_token (functests.execapplications.TestApplications) ... ok
test_appidp_token_404 (functests.execapplications.TestApplications) ... ok
test_applications_create (functests.execapplications.TestApplications) ... ok
test_applications_delete (functests.execapplications.TestApplications) ... ok
test_applications_list (functests.execapplications.TestApplications) ... ok
test_applications_regenerate (functests.execapplications.TestApplications) ... ok
test_applications_update (functests.execapplications.TestApplications) ... ok
test_archivist_token (functests.execapplications.TestApplications) ... skipped 'cannot run test as DATATRAILS_REFRESH_TOKEN is not set'
test_asset_create (functests.execassets.TestAssetCreate) ... ok
test_asset_create_event (functests.execassets.TestAssetCreate) ... ok
test_asset_create_merkle_log (functests.execassets.TestAssetCreate) ... ok
test_asset_create_with_fixtures (functests.execassets.TestAssetCreate) ... ok
test_asset_create_if_not_exists_with_bad_attachment (functests.execassets.TestAssetCreateIfNotExists) ... ok
test_asset_create_if_not_exists_with_bad_attachment_assetattachment (functests.execassets.TestAssetCreateIfNotExists) ... ok
test_attachment_info (functests.execattachments.TestAttachmentsCreate) ... skipped 'cannot run test as DATATRAILS_BLOB_IDENTITY is not set'
test_attachment_upload_and_download (functests.execattachments.TestAttachmentsCreate) ... ok
test_attachment_upload_and_download_allow_insecure (functests.execattachments.TestAttachmentsCreate) ... ok
test_attachment_upload_and_download_docx (functests.execattachments.TestAttachmentsCreate) ... ok
test_attachment_upload_and_download_strict (functests.execattachments.TestAttachmentsCreate) ... ok
test_attachment_malware_scan1 (functests.execattachments.TestAttachmentstMalware) ... ok
test_attachment_malware_scan2 (functests.execattachments.TestAttachmentstMalware) ... ok
test_attachment_malware_scan3 (functests.execattachments.TestAttachmentstMalware) ... ok
test_attachment_malware_scan4 (functests.execattachments.TestAttachmentstMalware) ... ok
test_01_create_artist_albuminfo (functests.execnotebooks.TestNotebooks) ... ok
test_02_find_artist_create_coverart (functests.execnotebooks.TestNotebooks) ... ok
test_03_find_artist_addtl_albuminfo (functests.execnotebooks.TestNotebooks) ... ok
test_create_event_with_verified_domain (functests.execnotebooks.TestNotebooks) ... ok
test_share_album_release_recordlabel (functests.execnotebooks.TestNotebooks) ... skipped 'Requires root access credentials -- see #7742'
test_share_album_release_user (functests.execnotebooks.TestNotebooks) ... skipped 'Requires root access credentials -- see #7742'
test_share_artist_asset_recordlabel (functests.execnotebooks.TestNotebooks) ... skipped 'Requires root access credentials -- see #7742'
test_share_artist_asset_user (functests.execnotebooks.TestNotebooks) ... skipped 'Requires root access credentials - see #7742'
test_asset_create_if_not_exists_with_bad_attachment_assetattachment (functests.execpublicassets.TestPublicAssetCreate) ... ok
test_public_asset_create (functests.execpublicassets.TestPublicAssetCreate) ... ok
test_public_asset_create_event (functests.execpublicassets.TestPublicAssetCreate) ... ok
test_runner_door_entry (functests.execrunner.TestRunner) ... ok
test_runner_estate_info (functests.execrunner.TestRunner) ... ok
test_runner_subjects (functests.execrunner.TestRunner) ... ok
test_runner_wipp (functests.execrunner.TestRunner) ... ok
test_subjects_count (functests.execsubjects.TestSubjects) ... ok
test_subjects_create (functests.execsubjects.TestSubjects) ... ok
test_subjects_create_b64 (functests.execsubjects.TestSubjects) ... ok
test_subjects_delete (functests.execsubjects.TestSubjects) ... ok
test_subjects_list (functests.execsubjects.TestSubjects) ... ok
test_subjects_update (functests.execsubjects.TestSubjects) ... ok

----------------------------------------------------------------------
Ran 50 tests in 74.953s

OK (skipped=8)
task pipeline-functests
task: [about] ./scripts/builder.sh ./scripts/version.sh
task: [pipeline-functests] ./scripts/builder.sh ./scripts/pipeline_functests.sh

Running tests...
----------------------------------------------------------------------
  test_access_policies_share_asset_with_different_attributes (functests.execaccess_policies.TestAccessPoliciesShare) ... skip (0.002s)
  test_access_policies_share_assets_symmetrically (functests.execaccess_policies.TestAccessPoliciesShare) ... skip (0.005s)
  test_access_policies_create (functests.execaccess_policies.TestAccessPoliciesSimple) ... ok (0.281s)
  test_access_policies_delete (functests.execaccess_policies.TestAccessPoliciesSimple) ... ok (0.209s)
  test_access_policies_list (functests.execaccess_policies.TestAccessPoliciesSimple) ... ok (0.635s)
  test_access_policies_update (functests.execaccess_policies.TestAccessPoliciesSimple) ... ok (0.403s)
  test_appidp_token (functests.execapplications.TestApplications) ... ok (0.531s)
  test_appidp_token_404 (functests.execapplications.TestApplications) ... ok (0.452s)
  test_applications_create (functests.execapplications.TestApplications) ... ok (0.222s)
  test_applications_delete (functests.execapplications.TestApplications) ... ok (0.254s)
  test_applications_list (functests.execapplications.TestApplications) ... ok (0.306s)
  test_applications_regenerate (functests.execapplications.TestApplications) ... ok (0.330s)
  test_applications_update (functests.execapplications.TestApplications) ... ok (0.255s)
  test_archivist_token (functests.execapplications.TestApplications) ... skip (0.005s)
  test_asset_create (functests.execassets.TestAssetCreate) ... ok (2.196s)
  test_asset_create_event (functests.execassets.TestAssetCreate) ... ok (2.129s)
  test_asset_create_merkle_log (functests.execassets.TestAssetCreate) ... ok (1.085s)
  test_asset_create_with_fixtures (functests.execassets.TestAssetCreate) ... ok (0.589s)
  test_asset_create_if_not_exists_with_bad_attachment (functests.execassets.TestAssetCreateIfNotExists) ... ok (0.185s)
  test_asset_create_if_not_exists_with_bad_attachment_assetattachment (functests.execassets.TestAssetCreateIfNotExists) ... ok (0.267s)
  test_attachment_info (functests.execattachments.TestAttachmentsCreate) ... skip (0.002s)
  test_attachment_upload_and_download (functests.execattachments.TestAttachmentsCreate) ... ok (0.175s)
  test_attachment_upload_and_download_allow_insecure (functests.execattachments.TestAttachmentsCreate) ... ok (0.274s)
  test_attachment_upload_and_download_docx (functests.execattachments.TestAttachmentsCreate) ... ok (0.214s)
  test_attachment_upload_and_download_strict (functests.execattachments.TestAttachmentsCreate) ... ok (0.222s)
  test_attachment_malware_scan1 (functests.execattachments.TestAttachmentstMalware) ... ok (0.236s)
  test_attachment_malware_scan2 (functests.execattachments.TestAttachmentstMalware) ... ok (0.200s)
  test_attachment_malware_scan3 (functests.execattachments.TestAttachmentstMalware) ... ok (0.915s)
  test_attachment_malware_scan4 (functests.execattachments.TestAttachmentstMalware) ... ok (0.178s)
  test_01_create_artist_albuminfo (functests.execnotebooks.TestNotebooks) ... ok (2.625s)
  test_02_find_artist_create_coverart (functests.execnotebooks.TestNotebooks) ... ok (2.478s)
  test_03_find_artist_addtl_albuminfo (functests.execnotebooks.TestNotebooks) ... ok (2.632s)
  test_create_event_with_verified_domain (functests.execnotebooks.TestNotebooks) ... ok (4.064s)
  test_share_album_release_recordlabel (functests.execnotebooks.TestNotebooks) ... skip (0.002s)
  test_share_album_release_user (functests.execnotebooks.TestNotebooks) ... skip (0.002s)
  test_share_artist_asset_recordlabel (functests.execnotebooks.TestNotebooks) ... skip (0.002s)
  test_share_artist_asset_user (functests.execnotebooks.TestNotebooks) ... skip (0.002s)
  test_asset_create_if_not_exists_with_bad_attachment_assetattachment (functests.execpublicassets.TestPublicAssetCreate) ... ok (31.311s)
  test_public_asset_create (functests.execpublicassets.TestPublicAssetCreate) ... ok (1.474s)
  test_public_asset_create_event (functests.execpublicassets.TestPublicAssetCreate) ... ok (1.446s)
  test_runner_door_entry (functests.execrunner.TestRunner) ... ok (4.313s)
  test_runner_estate_info (functests.execrunner.TestRunner) ... ok (0.181s)
  test_runner_subjects (functests.execrunner.TestRunner) ... ok (0.683s)
  test_runner_wipp (functests.execrunner.TestRunner) ... ok (5.867s)
  test_subjects_count (functests.execsubjects.TestSubjects) ... ok (0.120s)
  test_subjects_create (functests.execsubjects.TestSubjects) ... ok (0.133s)
  test_subjects_create_b64 (functests.execsubjects.TestSubjects) ... ok (0.158s)
  test_subjects_delete (functests.execsubjects.TestSubjects) ... ok (0.215s)
  test_subjects_list (functests.execsubjects.TestSubjects) ... ok (0.185s)
  test_subjects_update (functests.execsubjects.TestSubjects) ... ok (0.210s)

----------------------------------------------------------------------
Ran 50 tests in 71.310s

OK (skipped=8)

Generating XML reports...
Generated XML report: ./functest-results/TEST-functests.execaccess_policies.TestAccessPoliciesSimple-20250407154505.xml
Generated XML report: ./functest-results/TEST-functests.execapplications.TestApplications-20250407154505.xml
Generated XML report: ./functest-results/TEST-functests.execassets.TestAssetCreate-20250407154505.xml
Generated XML report: ./functest-results/TEST-functests.execassets.TestAssetCreateIfNotExists-20250407154505.xml
Generated XML report: ./functest-results/TEST-functests.execattachments.TestAttachmentsCreate-20250407154505.xml
Generated XML report: ./functest-results/TEST-functests.execattachments.TestAttachmentstMalware-20250407154505.xml
Generated XML report: ./functest-results/TEST-functests.execnotebooks.TestNotebooks-20250407154505.xml
Generated XML report: ./functest-results/TEST-functests.execpublicassets.TestPublicAssetCreate-20250407154505.xml
Generated XML report: ./functest-results/TEST-functests.execrunner.TestRunner-20250407154505.xml
Generated XML report: ./functest-results/TEST-functests.execsubjects.TestSubjects-20250407154505.xml
Generated XML report: ./functest-results/TEST-functests.execaccess_policies.TestAccessPoliciesShare-20250407154505.xml

AB#10634

@eccles eccles force-pushed the dev/paul/10634-remove-locations branch from 865881e to de6c8b7 Compare April 7, 2025 15:43
@eccles eccles marked this pull request as ready for review April 7, 2025 15:43
@eccles eccles marked this pull request as draft April 7, 2025 15:52
@eccles eccles force-pushed the dev/paul/10634-remove-locations branch 3 times, most recently from b80915a to 08c9d3c Compare April 7, 2025 16:11
@eccles eccles marked this pull request as ready for review April 7, 2025 16:21
@eccles eccles force-pushed the dev/paul/10634-remove-locations branch 2 times, most recently from 399a038 to 73cbdf9 Compare April 8, 2025 12:55
j-hartley
j-hartley previously approved these changes Apr 22, 2025
View reviewed changes
@eccles eccles force-pushed the dev/paul/10634-remove-locations branch from 73cbdf9 to 48d6bdc Compare April 22, 2025 14:56
@eccles
Remove locations
1d1ec8a 
Also fix all dependabot alerts

AB#10634

Signed-off-by: Paul Hewlett <phewlett76@gmail.com>
@eccles eccles force-pushed the dev/paul/10634-remove-locations branch from 48d6bdc to 1d1ec8a Compare April 22, 2025 15:06
@eccles eccles requested a review from j-hartley April 22, 2025 15:07
@eccles eccles enabled auto-merge (squash) April 22, 2025 15:08
@eccles eccles merged commit fa0e3ad into main Apr 22, 2025
13 checks passed
@eccles eccles deleted the dev/paul/10634-remove-locations branch April 22, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@j-hartley j-hartley j-hartley approved these changes

@waarg waarg Awaiting requested review from waarg

@wp0pw wp0pw Awaiting requested review from wp0pw

@honourfish honourfish Awaiting requested review from honourfish

@landintrees landintrees Awaiting requested review from landintrees

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eccles @j-hartley